Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress outdated warning emitted by auto-gened protobuf code #1282

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

tsmith023
Copy link
Contributor

@tsmith023 tsmith023 commented Sep 13, 2024

Removes the warning as documented in grpc/grpc#37609 from appearing during client usage

@tsmith023 tsmith023 requested a review from dirkkul September 13, 2024 08:30
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 merged commit 8c54d6e into main Sep 13, 2024
48 of 49 checks passed
@tsmith023 tsmith023 deleted the grpc/suppress-outdated-proto-warning branch September 13, 2024 10:02
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (6234608) to head (624e2e2).
Report is 144 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
- Coverage   94.42%   94.38%   -0.05%     
==========================================
  Files         215      220       +5     
  Lines       20686    20953     +267     
==========================================
+ Hits        19533    19776     +243     
- Misses       1153     1177      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants