Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palm to google #1329

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Palm to google #1329

merged 5 commits into from
Oct 14, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Oct 10, 2024

  • deprecates *-palm methods
  • adds *-google methods instead
  • warnings for everything
  • still sends "*-palm" to weaviate as older versions do not support *-google (everything pre-1.27)
  • removes some unneeded classes that we added during the named vectors introduction

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.26%. Comparing base (624e2e2) to head (46a8dec).
Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   94.38%   94.26%   -0.13%     
==========================================
  Files         220      220              
  Lines       20953    21002      +49     
==========================================
+ Hits        19776    19797      +21     
- Misses       1177     1205      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul changed the base branch from main to dev/1.27 October 10, 2024 11:06
@dirkkul dirkkul merged commit 488188b into dev/1.27 Oct 14, 2024
50 checks passed
@dirkkul dirkkul deleted the palm_to_google branch October 14, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants