Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI testing and pkg building of Python3.8 #1333

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

tsmith023
Copy link
Contributor

Inline with the recent end-of-life of Python 3.8, this PR removes the testing of client in Python3.8 and the building of the package for use in a Python3.8 environment

@tsmith023 tsmith023 requested a review from dirkkul October 11, 2024 14:10
@tsmith023 tsmith023 requested a review from a team as a code owner October 11, 2024 14:10
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (3f68082) to head (4217ec7).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
- Coverage   94.38%   94.33%   -0.05%     
==========================================
  Files         220      220              
  Lines       20956    21003      +47     
==========================================
+ Hits        19779    19814      +35     
- Misses       1177     1189      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@dirkkul dirkkul merged commit 3b8191c into main Oct 13, 2024
43 checks passed
@dirkkul dirkkul deleted the chore/remove-3.8-support-from-ci-and-pkg branch October 13, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants