-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve throughput and resiliency of batching algo #1371
Conversation
- Removes locks from event loop - Handles mapping async resp in batch thread instead of event loop thread to remove data locks in async fn - Uses return of loop.schedule in batching thread to determine number of active requests without locks outside of async fn
Great to see you again! Thanks for the contribution. |
…ient into batch/refactor-logic-to-avoid-deadlocks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
- Coverage 94.38% 93.91% -0.48%
==========================================
Files 220 221 +1
Lines 20956 21301 +345
==========================================
+ Hits 19779 20004 +225
- Misses 1177 1297 +120 ☔ View full report in Codecov by Sentry. |
Additional overhead of locking in the main batch looping thread and doing all CPU there slows down the logic considerably. Closing in favour of #1270 |
Closes: #1332