Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reranker image with dummy in tests #1476

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Replace reranker image with dummy in tests #1476

merged 1 commit into from
Dec 12, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Dec 12, 2024

Cuts down start time for weaviate in CI by ~1min20sec

@dirkkul dirkkul requested a review from a team as a code owner December 12, 2024 12:04
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (a373ee6) to head (41b77aa).
Report is 174 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
- Coverage   93.98%   91.95%   -2.03%     
==========================================
  Files         221      174      -47     
  Lines       21332    14910    -6422     
==========================================
- Hits        20048    13711    -6337     
+ Misses       1284     1199      -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul merged commit bb491a8 into main Dec 12, 2024
41 checks passed
@dirkkul dirkkul deleted the remove_reranker branch December 12, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants