Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes to handle new v1.25 ListValue with BC #984

Merged
merged 11 commits into from
May 6, 2024

Conversation

tsmith023
Copy link
Contributor

@tsmith023 tsmith023 commented Mar 28, 2024

@tsmith023 tsmith023 requested a review from dirkkul March 28, 2024 12:40
@tsmith023 tsmith023 requested a review from a team as a code owner March 28, 2024 12:40
@tsmith023 tsmith023 changed the title Add changes to handle new v1.25 ListValue with BC Add changes to handle new v1.25 ListValue with BC Mar 28, 2024
@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 95.13%. Comparing base (22d588a) to head (7f4f757).

Files Patch % Lines
weaviate/collections/queries/base.py 88.46% 3 Missing ⚠️
test/collection/test_byteops.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev/1.25     #984      +/-   ##
============================================
- Coverage     95.14%   95.13%   -0.01%     
============================================
  Files           175      177       +2     
  Lines         17983    18057      +74     
============================================
+ Hits          17110    17179      +69     
- Misses          873      878       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul merged commit 09ad916 into dev/1.25 May 6, 2024
42 of 43 checks passed
@dirkkul dirkkul deleted the grpc/refactor-return-array-properties-2 branch May 6, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants