Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregate.hybrid method using GQL #992

Merged
merged 15 commits into from
May 3, 2024

Conversation

tsmith023
Copy link
Contributor

No description provided.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 marked this pull request as ready for review April 29, 2024 16:32
@tsmith023 tsmith023 requested a review from dirkkul April 29, 2024 16:32
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.65432% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 94.86%. Comparing base (05a5c96) to head (e19cde8).

Files Patch % Lines
weaviate/gql/aggregate.py 82.45% 10 Missing ⚠️
integration/test_collection_aggregate.py 84.74% 9 Missing ⚠️
weaviate/collections/aggregations/hybrid.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           hybrid_extension     #992      +/-   ##
====================================================
- Coverage             94.92%   94.86%   -0.07%     
====================================================
  Files                   175      176       +1     
  Lines                 18123    18270     +147     
====================================================
+ Hits                  17204    17331     +127     
- Misses                  919      939      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

properties=[Property(name="text", data_type=DataType.TEXT)],
vectorizer_config=Configure.Vectorizer.text2vec_contextionary(
vectorize_collection_name=False
),
)

collection = collection_maker()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker, but what is the point of this change?

@dirkkul dirkkul merged commit c0ce6ad into hybrid_extension May 3, 2024
43 checks passed
@dirkkul dirkkul deleted the hybrid_ext/aggregate-hybrid branch May 3, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants