-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): add tailwind config to webpack build dependencies #4519
Merged
chenjiahan
merged 1 commit into
web-infra-dev:main
from
chenjiahan:tailwindcss_cache_0825
Aug 25, 2023
Merged
feat(builder): add tailwind config to webpack build dependencies #4519
chenjiahan
merged 1 commit into
web-infra-dev:main
from
chenjiahan:tailwindcss_cache_0825
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0684946 The changes in this PR will be included in the next version bump. This PR includes changesets to release 268 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9aoy
approved these changes
Aug 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 0684946
This pull request refactors the cache plugin of the
@modern-js/builder
package to support adding tailwind config to webpack build dependencies. It also updates the code snippets and changesets of the tailwind config files in both English and Chinese documentation. This improves the code quality, performance, and user experience of the modern.js framework.Details
🤖 Generated by Copilot at 0684946
getBuildDependencies
incache.ts
(link)getBuildDependencies
to simplify the code of thebuilderPluginCache
function incache.ts
(link)findExists
function from@modern-js/utils
to return a fake tailwind config file path incache.test.ts
(link)Config
type fromtailwindcss
to the code snippets of the tailwind config files in the documentation (link, link, link, link)css.mdx
in the main-doc package (link, link)use-tailwindcss.mdx
in the module-doc package (link, link)Related Issue
Checklist
pnpm run change
.