Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tailwindcss): mark designSystem as deprecated #4521

Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Aug 25, 2023

Summary

Ref: #4509

🤖 Generated by Copilot at d7e611d

This pull request updates the documentation and the code of Modern.js and Module Tools to reflect the changes in the Tailwind CSS integration and the removal of the source.designSystem and designSystem options. It also deletes two unused files related to the theme configuration. It affects the ./packages/document and ./packages/solutions directories and their subdirectories. It includes both English and Chinese versions of the documentation.

Details

🤖 Generated by Copilot at d7e611d

  • Remove the source.designSystem option and replace it with the theme option of Tailwind CSS in the documentation and the code (link, link, link, link, link, link, link, link, link, link, link, link)
  • Delete the files packages/document/module-doc/docs/en/guide/advance/theme-config.mdx and packages/document/module-doc/docs/zh/guide/advance/theme-config.mdx as they are no longer relevant (link, link)
  • Fix a minor formatting issue in the code block title of packages/document/module-doc/docs/en/api/config/build-config.mdx and packages/document/module-doc/docs/zh/api/config/build-config.mdx by adding a space before the ts keyword (link, link)
  • Remove the designSystem property from the SetupFunction interface in the template file packages/generator/generators/doc-generator/templates/docs/zh/guide/install.mdx (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

⚠️ No Changeset found

Latest commit: d7e611d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -5.62% ⚠️

Comparison is base (99693f0) 57.59% compared to head (d7e611d) 51.98%.
Report is 1043 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4521      +/-   ##
==========================================
- Coverage   57.59%   51.98%   -5.62%     
==========================================
  Files         672      673       +1     
  Lines       17794    18439     +645     
  Branches     3876     4275     +399     
==========================================
- Hits        10249     9585     -664     
- Misses       6934     8163    +1229     
- Partials      611      691      +80     

see 452 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@10Derozan 10Derozan merged commit 0d915fa into web-infra-dev:main Aug 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants