-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-proxy): failed to run networksetup command in Windows #4700
Conversation
🦋 Changeset detectedLatest commit: a0a6c9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 257 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4700 +/- ##
==========================================
- Coverage 57.59% 53.72% -3.87%
==========================================
Files 672 664 -8
Lines 17794 18113 +319
Branches 3876 4149 +273
==========================================
- Hits 10249 9732 -517
- Misses 6934 7720 +786
- Partials 611 661 +50 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at e8b0d1f
This pull request fixes a bug in the
@modern-js/plugin-proxy
package that caused errors when running on non-macOS platforms. It adds OS checks to themacProxyManager
module and updates the changeset file.Details
🤖 Generated by Copilot at e8b0d1f
@modern-js/plugin-proxy
package and fixing a bug related to macOS proxy settings (link)networksetup
command inmacProxyManager.ts
(link, link, link)getNetworkType
function if not macOS (link)enableGlobalProxy
function if not macOS (link)isMacOS
to check theprocess.platform
property (link)Related Issue
Checklist
pnpm run change
.