Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapted to Rspack v0.7 incompatible changes #2352

Merged
merged 2 commits into from
May 15, 2024

Conversation

9aoy
Copy link
Collaborator

@9aoy 9aoy commented May 15, 2024

Summary

Adapting rspack 0.7, use outputFileSystem.stat instead of outputFileSystem.existsSync because outputFileSystem.existsSync is not a standard API in the rspack / webpack outputFileSystem interface.

Related Links

Rspack related PR:

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented May 15, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit c9c590e
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66448962022c9400081b3a23
😎 Deploy Preview https://deploy-preview-2352--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@9aoy 9aoy requested a review from chenjiahan May 15, 2024 10:41
@9aoy 9aoy enabled auto-merge (squash) May 15, 2024 11:42
@chenjiahan chenjiahan changed the title chore: adapted to rspack 0.7 chore: adapted to rspack 0.7 incompatible changes May 15, 2024
@chenjiahan chenjiahan changed the title chore: adapted to rspack 0.7 incompatible changes chore: adapted to Rspack v0.7 incompatible changes May 15, 2024
@9aoy 9aoy merged commit 696cec3 into web-infra-dev:main May 15, 2024
12 checks passed
@9aoy 9aoy deleted the fix/rspack-outputFileSystem branch May 15, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants