-
-
Notifications
You must be signed in to change notification settings - Fork 232
test(e2e): move plugins config into config object in test cases #6247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes the test configuration structure by moving the plugins parameter from being passed as a separate argument to the e2e test helper functions into the config object. This improves consistency across all test cases and aligns with the standard Rsbuild configuration pattern.
- Refactors the e2e helper API to eliminate the separate
pluginsparameter - Updates all test cases to use
config.pluginsinstead of the root-levelpluginsproperty - Adds plugin configurations to rsbuild.config.ts files where tests were previously relying on inline plugin configuration
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/helper/jsApi.ts | Removes plugins parameter from createRsbuild, dev, and build functions |
| e2e/cases/syntax-es/decorator-config/index.test.ts | Moves plugins into config object |
| e2e/cases/syntax-es/decorator-2022-03/index.test.ts | Moves plugins into config object and fixes bracket placement |
| e2e/cases/server/preview/index.test.ts | Moves plugins into config object |
| e2e/cases/server/html-fallback/index.test.ts | Fixes bracket placement for plugins array |
| e2e/cases/server/history-api-fallback/historyApiFallback.test.ts | Moves plugins into config object |
| e2e/cases/plugin-vue/split-chunks/index.test.ts | Moves plugins into config object |
| e2e/cases/plugin-svelte/hmr/index.test.ts | Removes inline plugin configuration, relies on rsbuild config |
| e2e/cases/plugin-solid/index.test.ts | Moves plugins into config object |
| e2e/cases/plugin-react/split-chunk/index.test.ts | Moves plugins into config object |
| e2e/cases/plugin-babel/decorator/index.test.ts | Moves plugins into config object and fixes bracket placement |
| e2e/cases/plugin-babel/basic/index.test.ts | Moves plugins into config object and fixes bracket placement |
| e2e/cases/plugin-api/plugin-process-assets-by-environments/index.test.ts | Moves plugins into config object |
| e2e/cases/plugin-api/async-plugin/index.test.ts | Moves plugins into config object |
| e2e/cases/performance/split-chunk-by-module/rsbuild.config.ts | Adds plugin configuration to config file |
| e2e/cases/performance/split-chunk-by-module/index.test.ts | Updates test to use config file instead of inline plugins |
| e2e/cases/performance/resource-hints-preload/index.test.ts | Moves plugins into config object |
| e2e/cases/performance/resource-hints-prefetch/index.test.ts | Moves plugins into config object |
| e2e/cases/output/legal-comments/index.test.ts | Moves plugins into config object |
| e2e/cases/output/externals/index.test.ts | Moves plugins into config object |
| e2e/cases/output/data-uri-limit/assets.test.ts | Restructures config merging to include plugins |
| e2e/cases/html/inject/index.test.ts | Moves plugins into config object |
| e2e/cases/css/css-modules-dom/rsbuild.config.ts | Adds plugin configuration to config file |
| e2e/cases/css/css-modules-dom/index.test.ts | Updates test to use config file instead of inline plugins |
| e2e/cases/assets/inline-query/rsbuild.config.ts | Adds plugin configuration to config file |
| e2e/cases/assets/inline-query/index.test.ts | Updates test to use config file instead of inline plugins |
| e2e/cases/assets/inline-query-false/rsbuild.config.ts | Adds plugin configuration to config file |
| e2e/cases/assets/inline-query-false/index.test.ts | Updates test to use config file instead of inline plugins |
| e2e/cases/assets/inline-query-auto/rsbuild.config.ts | Adds plugin configuration to config file |
| e2e/cases/assets/inline-query-auto/index.test.ts | Updates test to use config file instead of inline plugins |
Comments suppressed due to low confidence (1)
e2e/cases/server/html-fallback/index.test.ts:1
- The
pluginsarray is placed outside the config object. It should be moved inside the config object to align with the standardization effort.
import { join } from 'node:path';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Summary
This change standardizes the test configuration by moving
pluginsfrom the root level into theconfigobject. It improves consistency across all test cases.Checklist