Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

This change standardizes the test configuration by moving plugins from the root level into the config object. It improves consistency across all test cases.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 25, 2025 02:48
@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 4ec8158
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68d4ad76c43a080008738fb0
😎 Deploy Preview https://deploy-preview-6247--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the test configuration structure by moving the plugins parameter from being passed as a separate argument to the e2e test helper functions into the config object. This improves consistency across all test cases and aligns with the standard Rsbuild configuration pattern.

  • Refactors the e2e helper API to eliminate the separate plugins parameter
  • Updates all test cases to use config.plugins instead of the root-level plugins property
  • Adds plugin configurations to rsbuild.config.ts files where tests were previously relying on inline plugin configuration

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
e2e/helper/jsApi.ts Removes plugins parameter from createRsbuild, dev, and build functions
e2e/cases/syntax-es/decorator-config/index.test.ts Moves plugins into config object
e2e/cases/syntax-es/decorator-2022-03/index.test.ts Moves plugins into config object and fixes bracket placement
e2e/cases/server/preview/index.test.ts Moves plugins into config object
e2e/cases/server/html-fallback/index.test.ts Fixes bracket placement for plugins array
e2e/cases/server/history-api-fallback/historyApiFallback.test.ts Moves plugins into config object
e2e/cases/plugin-vue/split-chunks/index.test.ts Moves plugins into config object
e2e/cases/plugin-svelte/hmr/index.test.ts Removes inline plugin configuration, relies on rsbuild config
e2e/cases/plugin-solid/index.test.ts Moves plugins into config object
e2e/cases/plugin-react/split-chunk/index.test.ts Moves plugins into config object
e2e/cases/plugin-babel/decorator/index.test.ts Moves plugins into config object and fixes bracket placement
e2e/cases/plugin-babel/basic/index.test.ts Moves plugins into config object and fixes bracket placement
e2e/cases/plugin-api/plugin-process-assets-by-environments/index.test.ts Moves plugins into config object
e2e/cases/plugin-api/async-plugin/index.test.ts Moves plugins into config object
e2e/cases/performance/split-chunk-by-module/rsbuild.config.ts Adds plugin configuration to config file
e2e/cases/performance/split-chunk-by-module/index.test.ts Updates test to use config file instead of inline plugins
e2e/cases/performance/resource-hints-preload/index.test.ts Moves plugins into config object
e2e/cases/performance/resource-hints-prefetch/index.test.ts Moves plugins into config object
e2e/cases/output/legal-comments/index.test.ts Moves plugins into config object
e2e/cases/output/externals/index.test.ts Moves plugins into config object
e2e/cases/output/data-uri-limit/assets.test.ts Restructures config merging to include plugins
e2e/cases/html/inject/index.test.ts Moves plugins into config object
e2e/cases/css/css-modules-dom/rsbuild.config.ts Adds plugin configuration to config file
e2e/cases/css/css-modules-dom/index.test.ts Updates test to use config file instead of inline plugins
e2e/cases/assets/inline-query/rsbuild.config.ts Adds plugin configuration to config file
e2e/cases/assets/inline-query/index.test.ts Updates test to use config file instead of inline plugins
e2e/cases/assets/inline-query-false/rsbuild.config.ts Adds plugin configuration to config file
e2e/cases/assets/inline-query-false/index.test.ts Updates test to use config file instead of inline plugins
e2e/cases/assets/inline-query-auto/rsbuild.config.ts Adds plugin configuration to config file
e2e/cases/assets/inline-query-auto/index.test.ts Updates test to use config file instead of inline plugins
Comments suppressed due to low confidence (1)

e2e/cases/server/html-fallback/index.test.ts:1

  • The plugins array is placed outside the config object. It should be moved inside the config object to align with the standardization effort.
import { join } from 'node:path';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit 893a85a into main Sep 25, 2025
12 checks passed
@chenjiahan chenjiahan deleted the test_e2e_config_0925 branch September 25, 2025 02:59
@chenjiahan chenjiahan mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants