Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

  • Rename variables for better clarity
  • Simplify error clearing and update checking logic

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 27, 2025 02:56
@netlify
Copy link

netlify bot commented Sep 27, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 4e09365
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68d753eb58eb88000830f432
😎 Deploy Preview https://deploy-preview-6266--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🔴 down 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the HMR client code to improve variable naming and simplify error handling logic. The changes focus on making the code more readable and consistent.

  • Renamed variables for better clarity (e.g., lastCompilationHashlastHash, hasCompileErrorshasBuildErrors)
  • Simplified error clearing logic by consolidating state management into clearBuildErrors() function
  • Unified message handling by replacing separate errorMessages array with generic messages array

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit f1a78de into main Sep 27, 2025
11 checks passed
@chenjiahan chenjiahan deleted the hmr_client_0927 branch September 27, 2025 03:57
@chenjiahan chenjiahan mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants