Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Checks for stats.file first before falling back to stats.moduleName for better error reporting. This ensures custom file paths take precedence over module names when available.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 29, 2025 06:27
@netlify
Copy link

netlify bot commented Sep 29, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 383b4fe
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68da279ca3dc9b0008bdae9d
😎 Deploy Preview https://deploy-preview-6281--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🔴 down 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the file name resolution logic in error reporting to prioritize custom file paths over module names. The change ensures that when both stats.file and stats.moduleName are available, the custom file path is used first for better error reporting clarity.

  • Reorders the priority of file path resolution to check stats.file before stats.moduleName
  • Consolidates the file resolution logic into a single variable assignment
  • Removes the fallback logic that previously checked stats.file last

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit 3133571 into main Sep 29, 2025
11 checks passed
@chenjiahan chenjiahan deleted the stats_file_0929 branch September 29, 2025 06:41
@chenjiahan chenjiahan mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants