Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

Replace the deprecated url.parse and memoized function with direct URL constructor.

url.parse has been deprecated since Node 24:

Screenshot 2025-09-29 at 16 02 31

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 29, 2025 08:12
@netlify
Copy link

netlify bot commented Sep 29, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 9f3cb4d
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68da3f6e1e6dda0008588248
😎 Deploy Preview https://deploy-preview-6284--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 61 (🔴 down 11 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the deprecated url.parse function with the modern URL constructor in the assets middleware. The deprecated url.parse was causing warnings in Node.js 24+.

  • Removes dependency on deprecated url.parse and associated memoization
  • Simplifies URL parsing logic using the standard URL constructor
  • Maintains the same URL decoding functionality with qsUnescape

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chenjiahan chenjiahan merged commit 8e02d6e into main Sep 29, 2025
12 checks passed
@chenjiahan chenjiahan deleted the replace_url_parse_0929 branch September 29, 2025 08:29
@chenjiahan chenjiahan mentioned this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants