perf: remove module code generation result cache

web-infra-dev · Dec 5, 2024 · 0d1d075 · 0d1d075
1 parent 29b77a1
commit 0d1d075
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/crates/rspack_core/src/concatenated_module.rs b/crates/rspack_core/src/concatenated_module.rs
@@ -17,9 +17,7 @@ use rspack_collections::{
 use rspack_error::{Diagnosable, Diagnostic, DiagnosticKind, Result, TraceableError};
 use rspack_hash::{HashDigest, HashFunction, RspackHash};
 use rspack_hook::define_hook;
-use rspack_sources::{
-  CachedSource, ConcatSource, RawStringSource, ReplaceSource, Source, SourceExt,
-};
+use rspack_sources::{ConcatSource, RawSource, RawStringSource, ReplaceSource, Source, SourceExt};
 use rspack_util::{ext::DynHash, itoa, source_map::SourceMapKind, swc::join_atom};
 use rustc_hash::FxHasher;
 use rustc_hash::{FxHashMap as HashMap, FxHashSet as HashSet};
@@ -1282,7 +1280,7 @@ impl Module for ConcatenatedModule {
     }
 
     let mut code_generation_result = CodeGenerationResult::default();
-    code_generation_result.add(SourceType::JavaScript, CachedSource::new(result).boxed());
+    code_generation_result.add(SourceType::JavaScript, result.boxed());
     code_generation_result.chunk_init_fragments = chunk_init_fragments;
     code_generation_result.runtime_requirements = runtime_requirements;
     code_generation_result

diff --git a/crates/rspack_core/src/normal_module.rs b/crates/rspack_core/src/normal_module.rs
@@ -18,7 +18,7 @@ use rspack_hook::define_hook;
 use rspack_loader_runner::{run_loaders, AdditionalData, Content, LoaderContext, ResourceData};
 use rspack_macros::impl_source_map_config;
 use rspack_sources::{
-  BoxSource, CachedSource, OriginalSource, RawBufferSource, RawStringSource, Source, SourceExt,
+  BoxSource, OriginalSource, RawBufferSource, RawSource, RawStringSource, Source, SourceExt,
   SourceMap, SourceMapSource, WithoutOriginalOptions,
 };
 use rspack_util::{
@@ -650,7 +650,7 @@ impl Module for NormalModule {
             concatenation_scope: concatenation_scope.as_mut(),
           },
         )?;
-        code_generation_result.add(*source_type, CachedSource::new(generation_result).boxed());
+        code_generation_result.add(*source_type, generation_result.boxed());
       }
       code_generation_result.concatenation_scope = concatenation_scope;
       Ok(code_generation_result)