Skip to content

Commit

Permalink
chore(infra/biome): switch the biome.jsonc to "off" (#7357)
Browse files Browse the repository at this point in the history
  • Loading branch information
SoonIter authored Jul 29, 2024
1 parent ebf8483 commit 20b45b8
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 18 deletions.
1 change: 1 addition & 0 deletions .typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ extend-exclude = [
"**/CHANGELOG.md",
"GOVERNANCE.md",
"pnpm-lock.yaml",
"biome.jsonc",
"scripts/test/diff.cjs",
"scripts/test/binary-path.cjs",
]
Expand Down
68 changes: 50 additions & 18 deletions biome.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -33,30 +33,62 @@
"linter": {
"enabled": true,
"rules": {
"recommended": false,
"recommended": true,
"a11y": {
"useButtonType": "error",
"noSvgWithoutTitle": "error"
"useKeyWithClickEvents": "off"
},
"complexity": {
"useArrowFunction": "error",
"useLiteralKeys": "error",
"noForEach": "error"
"noMultipleSpacesInRegularExpressionLiterals": "off",
"noStaticOnlyClass": "off",
"noThisInStatic": "off",
"noUselessConstructor": "off",
"noUselessTernary": "off",
"noBannedTypes": "off",
"useOptionalChain": "off",
"noUselessEmptyExport": "off",
"noExtraBooleanCast": "off"
},
"correctness": {
"noEmptyPattern": "off",
"noConstructorReturn": "off",
"noSwitchDeclarations": "off",
"noInvalidUseBeforeDeclaration": "off",
"noInnerDeclarations": "off",
"noVoidTypeReturn": "off"
},
"style": {
"noUnusedTemplateLiteral": "error",
"useNodejsImportProtocol": "error",
"noUselessElse": "error",
"noNonNullAssertion": "off",
"useNumberNamespace": "error",
"useConst": "error",
"useImportType": "error",
"useExportType": "error",
"useEnumInitializers": "error",
"useSelfClosingElements": "error"
"noCommaOperator": "off",
"useExponentiationOperator": "off",
"useShorthandFunctionType": "off",
"noArguments": "off",
"noInferrableTypes": "off",
"noVar": "off",
"noParameterAssign": "off",
"useTemplate": "off",
"useSingleVarDeclarator": "off",
"noNonNullAssertion": "off"
},
"performance": {
"noDelete": "off",
"noAccumulatingSpread": "off"
},
"security": {
"noGlobalEval": "off"
},
"suspicious": {
"noDoubleEquals": "error"
"noEmptyInterface": "off",
"noGlobalAssign": "off",
"noGlobalIsNan": "off",
"noFallthroughSwitchClause": "off",
"noConstEnum": "off",
"noConfusingVoidType": "off",
"noPrototypeBuiltins": "off",
"noImplicitAnyLet": "off",
"noAssignInExpressions": "off",
"noArrayIndexKey": "off",
"noRedundantUseStrict": "off",
"noControlCharactersInRegex": "off",
"noExplicitAny": "off"
}
},
"ignore": [
Expand All @@ -78,4 +110,4 @@
"clientKind": "git",
"useIgnoreFile": true
}
}
}

2 comments on commit 20b45b8

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
_selftest ✅ success
nx ❌ failure
rspress ✅ success
rsbuild ✅ success
examples ✅ success

@rspack-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2024-07-29 c507fe6) Current Change
10000_development-mode + exec 2.18 s ± 21 ms 2.18 s ± 24 ms -0.22 %
10000_development-mode_hmr + exec 693 ms ± 6.5 ms 704 ms ± 2.9 ms +1.58 %
10000_production-mode + exec 2.63 s ± 34 ms 2.68 s ± 33 ms +1.63 %
arco-pro_development-mode + exec 1.9 s ± 71 ms 1.91 s ± 75 ms +0.21 %
arco-pro_development-mode_hmr + exec 434 ms ± 1.3 ms 436 ms ± 2.5 ms +0.36 %
arco-pro_production-mode + exec 3.39 s ± 72 ms 3.41 s ± 71 ms +0.45 %
threejs_development-mode_10x + exec 1.77 s ± 26 ms 1.75 s ± 25 ms -1.45 %
threejs_development-mode_10x_hmr + exec 876 ms ± 8.8 ms 864 ms ± 11 ms -1.41 %
threejs_production-mode_10x + exec 5.49 s ± 29 ms 5.49 s ± 22 ms -0.09 %

Please sign in to comment.