Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: put errors on module instead of compilation #3103

Closed
ahabhgk opened this issue May 10, 2023 · 2 comments
Closed

refactor: put errors on module instead of compilation #3103

ahabhgk opened this issue May 10, 2023 · 2 comments
Assignees
@h-a-n-a @ahabhgk
Labels
team The issue/pr is created by the member of Rspack.

Comments

@ahabhgk
Copy link
Collaborator

ahabhgk commented May 10, 2023

What problem does this feature solve?

module owns errors instead of collect all errors on compilation, and summarize all errors when generate stats, then we can safely remove compilation.make_failed_module for increamental rebuild

What does the proposed API of configuration look like?

TODO
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 10, 2023
@hyf0 hyf0 added this to the Planned milestone May 11, 2023
@stale
Copy link

stale bot commented Jul 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Jul 15, 2023
@hardfist hardfist removed this from the Planned milestone Oct 6, 2023
@stale stale bot removed the stale label Oct 6, 2023
@stale Stale
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Dec 15, 2023
@ahabhgk ahabhgk mentioned this issue Dec 18, 2023
Merged
2 tasks
@stale stale bot removed the stale label Jan 15, 2024
@h-a-n-a h-a-n-a closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-a-n-a h-a-n-a

@ahabhgk ahabhgk

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hardfist @h-a-n-a @ahabhgk @hyf0