Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should emit diagnostics using shared reference of compilation #4433

Closed
Tracked by #4327
JSerFeng opened this issue Oct 25, 2023 · 6 comments
Closed
Tracked by #4327

Should emit diagnostics using shared reference of compilation #4433

JSerFeng opened this issue Oct 25, 2023 · 6 comments
Assignees
@h-a-n-a
Labels
stale team The issue/pr is created by the member of Rspack.

Comments

@JSerFeng
Copy link
Collaborator

Some stages in plugin, it can only access shared reference of compilation, but we need mutable ref to push diagnostics
@JSerFeng JSerFeng mentioned this issue Oct 25, 2023
Open
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 25, 2023
@ahabhgk
Copy link
Collaborator

ahabhgk commented Oct 26, 2023

Which test blocked by this?

@JSerFeng
Copy link
Collaborator Author

configCases/css/conflicting-order should emit warnings

@stale Stale
Copy link

stale bot commented Dec 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Dec 26, 2023
@JSerFeng
Copy link
Collaborator Author

bump

@stale stale bot removed the stale label Dec 27, 2023
@stale Stale
Copy link

stale bot commented Feb 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Feb 25, 2024
@JSerFeng
Copy link
Collaborator Author

We can return diagnostics and make caller to handle diagnostics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h-a-n-a h-a-n-a

Labels
stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@h-a-n-a @ahabhgk @JSerFeng