Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support __webpack_is_included__ #4443

Closed
Tracked by #4327
ahabhgk opened this issue Oct 26, 2023 · 2 comments · Fixed by #5242
Closed
Tracked by #4327

support __webpack_is_included__ #4443

ahabhgk opened this issue Oct 26, 2023 · 2 comments · Fixed by #5242
Assignees
@bvanjoi
Labels
team The issue/pr is created by the member of Rspack.

Comments

@ahabhgk
Copy link
Collaborator

ahabhgk commented Oct 26, 2023 •
edited
Loading

https://webpack.js.org/api/module-variables/#__webpack_is_included__-webpack-specific
@ahabhgk ahabhgk mentioned this issue Oct 26, 2023
Open
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 26, 2023
@github-actions github-actions bot mentioned this issue Oct 26, 2023
Merged
2 tasks
@github-actions github-actions bot mentioned this issue Nov 7, 2023
Merged
2 tasks
This was referenced Nov 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Nov 29, 2023
Merged
Merged
Merged
Merged
Closed
This was referenced Dec 7, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Dec 18, 2023
Merged
Merged
Merged
This was referenced Dec 27, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Jan 3, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
@LingyuCoder
Copy link
Collaborator

This feature had been supported by #5087, but webpack test can not pass because of __webpack_is_included__("./module" + "Used"). This dependent on compile time evaluation. cc @bvanjoi

@github-actions github-actions bot mentioned this issue Jan 5, 2024
Merged
2 tasks
@bvanjoi
Copy link
Collaborator

bvanjoi commented Jan 5, 2024

/assign @bvanjoi

@bvanjoi bvanjoi mentioned this issue Jan 5, 2024
Merged
This was referenced Jan 5, 2024
Merged
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvanjoi bvanjoi

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: eval + op for binary expr bvanjoi/rspack
3 participants
@LingyuCoder @bvanjoi @ahabhgk