-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: improve determine_export_assignments #6431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
quininer
commented
May 1, 2024
.../rspack_plugin_javascript/src/dependency/esm/harmony_export_imported_specifier_dependency.rs
Show resolved
Hide resolved
quininer
changed the title
improve determine_export_assignments
perf: improve determine_export_assignments
May 1, 2024
github-actions
bot
added
the
release: performance
release: performance related release(mr only)
label
May 1, 2024
quininer
commented
May 1, 2024
.../rspack_plugin_javascript/src/dependency/esm/harmony_export_imported_specifier_dependency.rs
Outdated
Show resolved
Hide resolved
!bench |
📝 Benchmark detail: Open task failure |
📝 Benchmark detail: Open
|
📝 Benchmark detail: Open
Threshold exceeded: ["arco-pro_development-mode + exec","threejs_development-mode_10x + exec"] |
!bench |
📝 Benchmark detail: Open
|
* Use .chain instead of .clone + .push * eliminate Atom drop by avoiding redundant Atom clone * Remove IndexSet and insert directly into Vec.
* eliminate Atom clone * rewrite collect hidden_exports
* Use indexmap again
quininer
force-pushed
the
perf-js-plug-esm
branch
from
May 10, 2024 06:05
53ffddf
to
151a5a3
Compare
JSerFeng
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an optimization for
TypeScript
repo build hotspot. I did some performance tests before the 5-1, but now the results have been destroyed along with harddisk.Checklist