-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify file system code #8654
Merged
hardfist
merged 7 commits into
web-infra-dev:main
from
nilptr:nilptr/refactor/file-system
Dec 11, 2024
Merged
refactor: simplify file system code #8654
hardfist
merged 7 commits into
web-infra-dev:main
from
nilptr:nilptr/refactor/file-system
Dec 11, 2024
+267
−406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
2 tasks
…e duplicate closures refactor(rspack_fs_node): create new_fs_error to simplify code
nilptr
force-pushed
the
nilptr/refactor/file-system
branch
from
December 11, 2024 02:59
8f4ed07
to
04c2036
Compare
!bench |
📝 Benchmark detail: Open
|
hardfist
approved these changes
Dec 11, 2024
thanks again for your great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cherry pick refactor changes in #8643
ThreadsafeNodeFS
methods into promises to simplify the codefn <'a>() -> BoxFuture<'a, Result<()>>;
toasync fn() -> Result<()>
NodeFileStats
lacks theis_symlink
fieldChecklist