Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: bump miette v7 to reduce binary size #8694

Merged
merged 4 commits into from
Dec 13, 2024
Merged

perf: bump miette v7 to reduce binary size #8694

merged 4 commits into from
Dec 13, 2024

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Dec 13, 2024 •
edited
Loading

Summary

Currently Rspack depends on both mietee v5 and v7. This PR attempts to unify the mietee version to v7 to reduce the binary size.

  • cargo bloat in the main branch:
Screenshot 2024-12-13 at 13 46 44
  • cargo bloat in the current branch:
Screenshot 2024-12-13 at 13 47 56

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan marked this pull request as draft December 13, 2024 05:19
@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Dec 13, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 13, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a807c02
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/675bcf0ae4ee8100089a4e4c

@chenjiahan chenjiahan marked this pull request as ready for review December 13, 2024 06:59
@chenjiahan chenjiahan requested a review from h-a-n-a December 13, 2024 07:00
@chenjiahan chenjiahan merged commit 993b792 into main Dec 13, 2024
33 of 34 checks passed
@chenjiahan chenjiahan deleted the mietee_v7_1213 branch December 13, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Assignees

@chenjiahan chenjiahan

Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenjiahan @h-a-n-a