Skip to content

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Oct 22, 2025

Summary

Make the pnpm setup freezing problem in macOS failing fast

image

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 22, 2025 13:32
@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 24370b6
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68f8f2bbff8d330008d0825e

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a pnpm setup freezing issue on self-hosted macOS runners by configuring a mirror URL for Node.js downloads and adding a timeout to prevent indefinite hanging.

  • Adds a 5-minute timeout to the pnpm setup step to prevent indefinite freezing
  • Configures a Node.js distribution mirror for self-hosted macOS runners to improve download reliability

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/reusable-build-test.yml Adds timeout protection to pnpm setup step
.github/actions/pnpm/setup/action.yml Configures npmmirror.com as Node.js mirror for self-hosted Darwin runners

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

📦 Binary Size-limit

Comparing 24370b6 to chore(ci): fix flaky mf container-1-5 test cases (#11954) by pshu

🙈 Size remains the same at 47.82MB

@stormslowly stormslowly marked this pull request as draft October 22, 2025 13:57
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #11976 will not alter performance

Comparing chore/ci_pnpm_timeout_in_macos (24370b6) with main (e28e40e)

Summary

✅ 17 untouched

@stormslowly stormslowly changed the title chore(ci): use dist mirror for self hosted mac chore(ci): set timeout for pnpm setup action Oct 23, 2025
@stormslowly stormslowly marked this pull request as ready for review October 23, 2025 02:32
@chenjiahan chenjiahan merged commit ebea85e into main Oct 23, 2025
178 of 182 checks passed
@chenjiahan chenjiahan deleted the chore/ci_pnpm_timeout_in_macos branch October 23, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants