Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement builtins.provide by provide dependency #3799

Closed
wants to merge 3 commits into from

Conversation

underfin
Copy link
Collaborator

@underfin underfin commented Jul 19, 2023

Summary

close #3544 #3203

Test Plan

@underfin underfin requested review from a team, LingyuCoder, ahabhgk, ScriptedAlchemy and hyf0 July 19, 2023 11:10
@underfin underfin marked this pull request as draft July 19, 2023 11:11
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jul 19, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump").

@stale stale bot added the stale label Sep 17, 2023
@stale stale bot removed the stale label Sep 18, 2023
@ahabhgk
Copy link
Collaborator

ahabhgk commented Sep 18, 2023

blockers:

  1. new tree shaking implementation
  2. parser hook

@ahabhgk ahabhgk self-assigned this Oct 24, 2023
@hardfist
Copy link
Contributor

close this for stale

@hardfist hardfist closed this Nov 15, 2023
@chenjiahan chenjiahan deleted the refactor-provide branch December 10, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builtin provider should use ProviderDependency to implment this
3 participants