Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark regexp as None when it has g or y flag for context module #4457

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

bvanjoi
Copy link
Collaborator

@bvanjoi bvanjoi commented Oct 27, 2023

Fixes #4328

The g and y flags are likely irrelevant in the context module, so we can disregard them.

@bvanjoi bvanjoi requested a review from a team October 27, 2023 06:50
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 27, 2023
ahabhgk
ahabhgk previously approved these changes Oct 27, 2023
@bvanjoi bvanjoi enabled auto-merge October 27, 2023 07:15
@bvanjoi bvanjoi disabled auto-merge October 27, 2023 07:22
@bvanjoi bvanjoi enabled auto-merge October 27, 2023 07:57
@bvanjoi bvanjoi added this pull request to the merge queue Oct 27, 2023
Merged via the queue into web-infra-dev:main with commit 238cda8 Oct 27, 2023
12 checks passed
@bvanjoi bvanjoi deleted the fix-4305 branch October 27, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support regexp g flag for context module
2 participants