Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-driver): add execute module #4737

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat(plugin-driver): add execute module #4737

merged 1 commit into from
Nov 22, 2023

Conversation

JSerFeng
Copy link
Collaborator

@JSerFeng JSerFeng commented Nov 22, 2023 •
edited
Loading

Summary

Add execute module in plugin_driver

This is pre-request for importModule

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@JSerFeng JSerFeng requested a review from a team November 22, 2023 05:57
@JSerFeng JSerFeng requested a review from ahabhgk as a code owner November 22, 2023 05:57
@JSerFeng JSerFeng requested a review from a team November 22, 2023 05:57
@JSerFeng
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 22, 2023
@JSerFeng JSerFeng mentioned this pull request Nov 22, 2023
Merged
2 tasks
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 22, 2023
@JSerFeng JSerFeng added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 3ce9ced Nov 22, 2023
21 checks passed
@JSerFeng JSerFeng deleted the 11-22-feat_plugin-driver_add_execute_module branch November 22, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@hardfist hardfist Awaiting requested review from hardfist

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy

Assignees

@JSerFeng JSerFeng

Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSerFeng @ahabhgk