Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: url-dependency pos error #5397

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: url-dependency pos error #5397

merged 1 commit into from
Jan 22, 2024

Conversation

JSerFeng
Copy link
Collaborator

@JSerFeng JSerFeng commented Jan 22, 2024 •
edited
Loading

Summary

Current:

new URL("foo", import.meta.url).href
// become invalid syntax
new __webpack_require__.U(__webpack_require__('foo'))href;

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@JSerFeng JSerFeng requested review from a team, LingyuCoder and ahabhgk January 22, 2024 13:30
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jan 22, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 22, 2024
@JSerFeng JSerFeng enabled auto-merge (squash) January 22, 2024 13:46
@JSerFeng JSerFeng mentioned this pull request Jan 22, 2024
Merged
2 tasks
@JSerFeng JSerFeng merged commit 800542b into main Jan 22, 2024
22 checks passed
@JSerFeng JSerFeng deleted the fix/url-dep branch January 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

Assignees

@JSerFeng JSerFeng

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSerFeng @LingyuCoder