fix: add runtime condition for harmony reexport checked

crates/rspack_plugin_javascript/src/dependency/esm/harmony_export_imported_specifier_dependency.rs

@@ -4,15 +4,15 @@ use std::sync::Arc;
 use indexmap::{IndexMap, IndexSet};
 use rspack_collections::IdentifierSet;
 use rspack_core::{
-  create_exports_object_referenced, create_no_exports_referenced, get_exports_type,
+  create_exports_object_referenced, create_no_exports_referenced, filter_runtime, get_exports_type,
   process_export_info, property_access, property_name, string_of_used_name, AsContextDependency,
-  ConnectionState, Dependency, DependencyCategory, DependencyCondition, DependencyId,
-  DependencyTemplate, DependencyType, ErrorSpan, ExportInfoId, ExportInfoProvided,
+  ConditionalInitFragment, ConnectionState, Dependency, DependencyCategory, DependencyCondition,
+  DependencyId, DependencyTemplate, DependencyType, ErrorSpan, ExportInfoId, ExportInfoProvided,
   ExportNameOrSpec, ExportPresenceMode, ExportSpec, ExportsInfoId, ExportsOfExportsSpec,
   ExportsSpec, ExportsType, ExtendedReferencedExport, HarmonyExportInitFragment, ImportAttributes,
   InitFragmentExt, InitFragmentKey, InitFragmentStage, JavascriptParserOptions, ModuleDependency,
-  ModuleGraph, ModuleIdentifier, NormalInitFragment, RuntimeGlobals, RuntimeSpec, Template,
-  TemplateContext, TemplateReplaceSource, UsageState, UsedName,
+  ModuleGraph, ModuleIdentifier, NormalInitFragment, RuntimeCondition, RuntimeGlobals, RuntimeSpec,
+  Template, TemplateContext, TemplateReplaceSource, UsageState, UsedName,
 };
 use rspack_error::{
   miette::{MietteDiagnostic, Severity},
@@ -626,6 +626,16 @@ impl HarmonyExportImportedSpecifierDependency {
           let key = string_of_used_name(used_name.as_ref());
 
           if checked {
+            let key = InitFragmentKey::HarmonyImport(format!(
+              "harmony reexport (checked) {import_var} {name}"
+            ));
+            let runtime_condition = if self.weak() {
+              RuntimeCondition::Boolean(false)
+            } else if let Some(connection) = mg.connection_by_dependency(self.id()) {
+              filter_runtime(ctxt.runtime, |r| connection.is_target_active(mg, r))
+            } else {
+              RuntimeCondition::Boolean(true)
+            };
             let is_async = mg.is_async(&module_identifier).unwrap_or_default();
             let stmt = self.get_conditional_reexport_statement(
               ctxt,
@@ -634,16 +644,17 @@ impl HarmonyExportImportedSpecifierDependency {
               ids[0].clone(),
               ValueKey::Vec(ids),
             );
-            fragments.push(Box::new(NormalInitFragment::new(
+            fragments.push(Box::new(ConditionalInitFragment::new(
               stmt,
               if is_async {
                 InitFragmentStage::StageAsyncHarmonyImports
               } else {
                 InitFragmentStage::StageHarmonyImports
               },
               self.source_order,
-              InitFragmentKey::unique(),
+              key,
               None,
+              runtime_condition,
             )));
           } else {
             let used_name =

tests/webpack-test/configCases/graph/conditional-reexport/a.js

@@ -0,0 +1,5 @@
+import { utilA } from "./lib"
+
+it("should not emit error when running a.js (runtime a)", () => {
+  expect(utilA()).toBe("a");
+})

tests/webpack-test/configCases/graph/conditional-reexport/b.js

@@ -0,0 +1,5 @@
+import { utilB } from "./lib"
+
+it("should not emit error when running b.js (runtime b)", () => {
+  expect(utilB()).toBe("[object Object] common");
+})

tests/webpack-test/configCases/graph/conditional-reexport/lib/common/common.js

@@ -0,0 +1 @@
+export const common = 'common'

tests/webpack-test/configCases/graph/conditional-reexport/lib/common/index.js

@@ -0,0 +1,2 @@
+export * from "./common"
+export * from "./empty"

tests/webpack-test/configCases/graph/conditional-reexport/lib/index.js

@@ -0,0 +1,3 @@
+export * from "./util-a"
+export * from "./common"
+export * from "./util-b"

tests/webpack-test/configCases/graph/conditional-reexport/lib/util-a.js

@@ -0,0 +1,3 @@
+export function utilA() {
+  return 'a';
+}

tests/webpack-test/configCases/graph/conditional-reexport/lib/util-b.js

@@ -0,0 +1,5 @@
+import { common } from "./common"
+var b = ({}).toString(); // side effect, this will keep lib/index.js exist in the output, bailout the optimization from SideEffectsFlagPlugin
+export function utilB() {
+  return b + ' ' + common;
+}

tests/webpack-test/configCases/graph/conditional-reexport/test.config.js

@@ -0,0 +1,5 @@
+module.exports = {
+	findBundle() {
+		return ["./lib.js", "./a.js", "./b.js"];
+	}
+};

tests/webpack-test/configCases/graph/conditional-reexport/webpack.config.js

@@ -0,0 +1,25 @@
+/** @type {import("webpack").Configuration} */
+module.exports = {
+	entry: {
+		a: "./a.js",
+		b: "./b.js"
+	},
+	output: {
+		filename: "[name].js"
+	},
+	target: "web",
+	mode: "production",
+	optimization: {
+		concatenateModules: false,
+		splitChunks: {
+			cacheGroups: {
+				lib: {
+					name: "lib",
+					test: /lib/,
+					chunks: "all",
+					minSize: 0
+				}
+			}
+		}
+	}
+};