Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return url in CreateScriptUrlRuntimeModule #8088

Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix: return url in CreateScriptUrlRuntimeModule #8088

merged 3 commits into from
Oct 11, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Oct 11, 2024 •
edited
Loading

Summary

related to #7866 (comment)

should return url directly here when trustedTypes is none

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Oct 11, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a5f20c6
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6708dd5501ee670008469f26

@LingyuCoder LingyuCoder marked this pull request as ready for review October 11, 2024 11:21
@LingyuCoder LingyuCoder requested a review from ahabhgk October 11, 2024 11:21
@LingyuCoder LingyuCoder merged commit 3153da6 into main Oct 11, 2024
30 checks passed
@LingyuCoder LingyuCoder deleted the fix/create-script-url branch October 11, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@LingyuCoder LingyuCoder

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LingyuCoder @ahabhgk