Draft: consume js inputFileSystem on the rust side

[nilptr]

Summary

resolves #5091

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[netlify]

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	e4a3ede
🔍 Latest deploy log	https://app.netlify.com/sites/rspack/deploys/67583fcc24fdd40008056ea8

[nilptr]

Hi guys, I have been struggling to investigate the CI "Test Node 18" failure for 2 days. I feel I really need your help.

I believe my implementation can pass all the tests if the tests are run separately.
However, the tests will always be stuck in the config/builtin-swc-loader/swc-plugin case, when they are run concurrently.

My findings so far are that it's stuck in

rspack/packages/rspack-test-tools/src/runner/runner/cjs.ts

Line 142 in 9371531

fn.call(

even if the output is the same.

[hardfist]

thanks it maybe related to performance regression, block_on fs binding will cause huge performance regression

I think the biggest blocker now is rspack_resolver doesn't use async_fs, which cause it has to block_on on fs binging call, which will introduce huge performance regression web-infra-dev/rspack-resolver#34.

but we can still merge this pr first if we don't enable input_fs binding by default and when we solve the rspack_resolver async_fs problem, we can enable inputfs binding

[nilptr]

yeah, I also suspect the performance regression, but cannot prove it.

I'm afraid we cannot merge this PR now, because compiler.inputFileSystem has been set by default.

rspack/packages/rspack/src/rspack.ts

Lines 53 to 62 in 5ad5803

	function createCompiler(userOptions: RspackOptions): Compiler {
	const options = getNormalizedRspackOptions(userOptions);
	applyRspackOptionsBaseDefaults(options);
	assert(!isNil(options.context));
	const compiler = new Compiler(options.context, options);
	new NodeEnvironmentPlugin({
	infrastructureLogging: options.infrastructureLogging
	}).apply(compiler);

and

rspack/packages/rspack/src/node/NodeEnvironmentPlugin.ts

Lines 49 to 53 in 9e1205c

	const inputFileSystem: InputFileSystem = new CachedInputFileSystem(
	fs,
	60000
	);
	compiler.inputFileSystem = inputFileSystem;

if you feel the refactors in this pr are needed, I can create a new pr and cherry pick the refactor commits.

[hardfist]

yeah, I also suspect the performance regression, but cannot prove it.

I actually tried it before and revert cause huge performance regression introduced, you can test it in project with large modules like https://github.com/hardfist/performance-compare-ng/tree/master/apps/10000

[hardfist]

I'm afraid we cannot merge this PR now, because compiler.inputFileSystem has been set by default.

that's easy, you can just ignore the inputFileSystem in the rust side, it's actually current's behavior

[nilptr]

I disabled inputFileSystem on the js side in this PR.

I also created another branch and cherry-picked the refactor commits. maybe #8654 is exactly what you expect.

[hardfist]

I disabled inputFileSystem on the js side in this PR.

I also created another branch and cherry-picked the refactor commits. maybe #8654 is exactly what you expect.

yes, good job!