fix: wasm file not found error #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for WebAssembly (WASM) modules in Rstest by implementing a custom WASM file loader and integrating it with the runtime module system.
- Adds
readWasmFilefunction to load WASM files from asset files - Modifies the
async_wasm_loadingruntime module to use the custom WASM loader - Prevents WASM files from being externalized during bundling
- Adds an E2E test for WASM factorial function
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/runtime/worker/loadModule.ts | Implements readWasmFile function to load WASM files from asset files |
| packages/core/src/core/plugins/mockRuntime.ts | Patches async_wasm_loading runtime module to use custom WASM loader |
| packages/core/src/core/plugins/external.ts | Excludes WASM files from externalization |
| packages/core/src/utils/error.ts | Adds type guard for error.stack |
| e2e/wasm/index.test.ts | E2E test for WASM module loading |
| e2e/wasm/src/factorial.wasm.d.ts | TypeScript declaration for WASM module |
| e2e/wasm/src/factorial.wasm | Binary WASM file for testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix wasm file not found error
TODO: below error should be fixed after bump rspack 1.6.2+ web-infra-dev/rspack#12068
Related Links
#676
Checklist