Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ambient light sensor #2245

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add Ambient light sensor #2245

merged 2 commits into from
Nov 26, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Nov 14, 2024

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 14, 2024
Copy link
Collaborator

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix for the description comment would be great if it's actually needed, looks good otherwise.

@@ -0,0 +1,11 @@
name: Ambient light sensor
description: The `AmbientLightSensor` interface returns the current light level or illuminance of the ambient light around the device.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current light level or illuminance of the ambient light around the device

Are these two different things? The MDN docs only show the one property that I can see.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the sensor APIs are a bit weird, right? They receive sensor reading events, rather than returning data themselves?

features/ambient-light.yml Outdated Show resolved Hide resolved
@Elchi3 Elchi3 requested a review from ddbeck November 21, 2024 11:29
@Elchi3 Elchi3 mentioned this pull request Nov 21, 2024
@Elchi3 Elchi3 merged commit 9a85d66 into web-platform-dx:main Nov 26, 2024
3 checks passed
@Elchi3 Elchi3 deleted the ambient branch November 26, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants