Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move download and ping out of draft #2347

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Move download and ping out of draft #2347

merged 3 commits into from
Nov 28, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Nov 27, 2024

Not sure why it is a draft. Not seeing any context in #1449

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 27, 2024
@Elchi3 Elchi3 changed the title Move ping out of draft Move download and ping out of draft Nov 27, 2024
jamesnw
jamesnw approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also couldn't find any other issues explaining why these were draft. This looks good to me, but I won't merge immediately in case this rings any bells for anyone.

@autonome

This comment was marked as off-topic.

Sign in to view
@ddbeck ddbeck mentioned this pull request Nov 28, 2024
Open
ddbeck
ddbeck approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why Philip and I did these as drafts. Happy to see them un-drafted. Thank you!

@ddbeck ddbeck merged commit bebe956 into web-platform-dx:main Nov 28, 2024
3 checks passed
@Elchi3 Elchi3 deleted the ping branch November 28, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnw jamesnw jamesnw approved these changes

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Elchi3 @autonome @ddbeck @jamesnw