From 1b27850759ff5c0b7e8bf750e717c8f1d08da639 Mon Sep 17 00:00:00 2001 From: Mason Freed Date: Fri, 27 May 2022 09:01:33 -0700 Subject: [PATCH] Convert `popup=popup` to `popup=auto` or just `popup` Per the [1] resolution, `popup=popup` has been renamed to `popup=auto`. Additionally, per the [2] resolution, "boolean-like" behavior is also supported, such that `
` means the same thing as `
`. This CL implements both of these changes. Note that this CL has one case that still needs to be fixed:
To fix the above, I need to figure out how to specify the ReflectMissing and ReflectInvalid values so that they mean "null". [1] https://github.com/openui/open-ui/issues/491#issuecomment-1132165724 [2] https://github.com/openui/open-ui/issues/533#issuecomment-1138874090 Bug: 1307772 Change-Id: I6037c5322f7408ebd2c91690f89ecbc513c66bdb --- .../selectmenu-many-options.tentative.html | 2 +- .../selectmenu-nested.tentative.html | 4 +- ...trary-content-displayed-ref.tentative.html | 2 +- ...arbitrary-content-displayed.tentative.html | 2 +- .../selectmenu-parts-structure.tentative.html | 24 +++---- ...nu-popup-position-with-zoom.tentative.html | 8 +-- .../selectmenu-popup-position.tentative.html | 8 +-- .../selectmenu-popup.tentative.html | 4 +- ...enu-shadow-root-replacement.tentative.html | 4 +- ...ctmenu-value-selectedOption.tentative.html | 2 +- .../popup-anchor-idl-property.tentative.html | 2 +- .../popup-anchor-nesting.tentative.html | 4 +- .../popup-attribute-basic.tentative.html | 71 +++++++++++-------- ...pup-backdrop-appearance-ref.tentative.html | 2 +- .../popup-backdrop-appearance.tentative.html | 2 +- .../popups/popup-defaultopen-2.tentative.html | 4 +- .../popup-defaultopen-display.tentative.html | 4 +- .../popups/popup-defaultopen.tentative.html | 6 +- .../popups/popup-events.tentative.html | 2 +- .../popups/popup-focus.tentative.html | 36 +++++----- .../popup-hidden-display.tentative.html | 2 +- .../popup-inside-display-none.tentative.html | 2 +- .../popup-invoking-attribute.tentative.html | 5 +- ...pup-light-dismiss-on-scroll.tentative.html | 4 +- .../popups/popup-light-dismiss.tentative.html | 28 ++++---- ...opup-not-keyboard-focusable.tentative.html | 2 +- .../popups/popup-open-display.tentative.html | 2 +- ...p-open-overflow-display-ref.tentative.html | 6 +- ...popup-open-overflow-display.tentative.html | 6 +- .../popups/popup-removal-2.tentative.html | 2 +- .../popups/popup-removal.tentative.html | 2 +- .../popups/popup-shadow-dom.tentative.html | 14 ++-- .../popup-stacking-context.tentative.html | 2 +- .../popups/popup-stacking.tentative.html | 32 ++++----- ...opup-top-layer-interactions.tentative.html | 2 +- .../popups/popup-types.tentative.html | 8 +-- 36 files changed, 161 insertions(+), 151 deletions(-) diff --git a/html/semantics/forms/the-selectmenu-element/selectmenu-many-options.tentative.html b/html/semantics/forms/the-selectmenu-element/selectmenu-many-options.tentative.html index 2abb9d07e6863b..765845f0cb4df2 100644 --- a/html/semantics/forms/the-selectmenu-element/selectmenu-many-options.tentative.html +++ b/html/semantics/forms/the-selectmenu-element/selectmenu-many-options.tentative.html @@ -26,7 +26,7 @@ -
+
diff --git a/html/semantics/forms/the-selectmenu-element/selectmenu-nested.tentative.html b/html/semantics/forms/the-selectmenu-element/selectmenu-nested.tentative.html index fdbf50b93902db..bb80b706d054d3 100644 --- a/html/semantics/forms/the-selectmenu-element/selectmenu-nested.tentative.html +++ b/html/semantics/forms/the-selectmenu-element/selectmenu-nested.tentative.html @@ -8,7 +8,7 @@ -
+
@@ -18,7 +18,7 @@ -
+
diff --git a/html/semantics/forms/the-selectmenu-element/selectmenu-value-selectedOption.tentative.html b/html/semantics/forms/the-selectmenu-element/selectmenu-value-selectedOption.tentative.html index f477ddb90dda9a..b131559d032beb 100644 --- a/html/semantics/forms/the-selectmenu-element/selectmenu-value-selectedOption.tentative.html +++ b/html/semantics/forms/the-selectmenu-element/selectmenu-value-selectedOption.tentative.html @@ -40,7 +40,7 @@
Default custom selected-value text
-
+
diff --git a/html/semantics/popups/popup-anchor-idl-property.tentative.html b/html/semantics/popups/popup-anchor-idl-property.tentative.html index e5d9ca8c486e7b..fa4441d8bcdf1b 100644 --- a/html/semantics/popups/popup-anchor-idl-property.tentative.html +++ b/html/semantics/popups/popup-anchor-idl-property.tentative.html @@ -6,7 +6,7 @@ -
This is a popup
+
This is a popup
-
Popup
+
Popup
+
Popup
+
Popup
Popup
Popup
Non-popup
+
Non-popup
Non-popup
-
Non-popup
-
+
Outer popup -
+
Inner popup
diff --git a/html/semantics/popups/popup-defaultopen-display.tentative.html b/html/semantics/popups/popup-defaultopen-display.tentative.html index 179e07189b31ec..562137ab56bd59 100644 --- a/html/semantics/popups/popup-defaultopen-display.tentative.html +++ b/html/semantics/popups/popup-defaultopen-display.tentative.html @@ -4,8 +4,8 @@ -
This is a popup, which should be open upon load
-
This is a second popup with defaultopen, which should NOT be open upon load
+
This is a popup, which should be open upon load
+
This is a second popup with defaultopen, which should NOT be open upon load