HTML: BarProp objects #15815
Merged
HTML: BarProp objects #15815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 13, 2019
Also describe what happens when the browsing context is discarded. Tests: web-platform-tests/wpt#15815. Fixes #2579.
domenic
reviewed
Mar 13, 2019
| function assert_barProps(barPropObjects, visible) { | ||
| let lastBarProp = undefined; | ||
| for (let barProp of barPropObjects) { | ||
| const currentBarProp = barProp; |
There was a problem hiding this comment.
const currentBarProp of barPropObjects?
| barProps = ["locationbar", "menubar", "personalbar", "scrollbars", "statusbar", "toolbar"], | ||
| barPropObjects = barProps.map(val => frameW[val]); | ||
|
|
||
| assert_barProps(barPropObjects, true); |
There was a problem hiding this comment.
Honestly it's pretty surprising these count as visible for an iframe. Something for whatwg/html#4431 I suppose.
| assert_identical_barProps(barProps, openee, barPropObjects, true); | ||
|
|
||
| openee.onunload = t.step_func(() => { | ||
| assert_barProps(barPropObjects, true); |
There was a problem hiding this comment.
Whenever you use assert_barProps instead of assert_identical_barProps, I wonder to myself: does this mean they're supposed to have changed since the last time? If so, replacing it with an assertion that they are supposed to be different would be good. If not, replacing it with assert_identitical_barProps would be good.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 14, 2019
Also describe what happens when the browsing context is discarded. Tests: web-platform-tests/wpt#15815. Follow-up: #4431. Fixes #2579.
domenic
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/html#2579.