Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WPT for Partitioned Service Worker claim() #31678

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 18, 2021

Add WPT that tests that clients.claim() is properly partitioned
when storage partitioning is enabled.

(For chrome) Also runs the test as part of the third-party storage
partitioning virtual test suite.

Bug: 1246549
Change-Id: I26f6f64ad8c1a1a531fe7503cfeb43abc99b4397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289538
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944152}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Add WPT that tests that clients.claim() is properly partitioned
when storage partitioning is enabled.

(For chrome) Also runs the test as part of the third-party storage
partitioning virtual test suite.

Bug: 1246549
Change-Id: I26f6f64ad8c1a1a531fe7503cfeb43abc99b4397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3289538
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944152}
@foolip
Copy link
Member

foolip commented Nov 23, 2021

This was blocked by #31714, I'll close and reopen in the hope to get the #31715 workaround, which should unblock this.

@foolip foolip closed this Nov 23, 2021
@foolip foolip reopened this Nov 23, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 53d10f6 into master Nov 23, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-3289538 branch November 23, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants