Fix invalidation bug for <select> caret style #31705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 22, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3292448
branch
2 times, most recently
from
6ea49e4 to
a721cc6
Compare
Previously, setting the color (or likely other styles?) for a <select> after it was initially rendered would not result in an updated rendering of the caret. Fixed: 1269840 Change-Id: Iee971dea8beda969d1e40cbd2886ce05bd330f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292448 Commit-Queue: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#944372}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3292448
branch
from
a721cc6 to
b7fc2bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, setting the color (or likely other styles?) for a
<select> after it was initially rendered would not result in an
updated rendering of the caret.
Fixed: 1269840
Change-Id: Iee971dea8beda969d1e40cbd2886ce05bd330f17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3292448
Commit-Queue: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#944372}