Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in open-features-tokenization-noopener.html test. #5721

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 27, 2017

It was missing a comma.


This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

Notifying @jdm, @jgraham, @zcorpan, and @zqzhang. (Learn how reviewing works.)

@cdumez
Copy link
Contributor Author

cdumez commented Apr 27, 2017

@annevk @zcorpan r?

@cdumez cdumez requested a review from lyzadanger April 27, 2017 17:14
@ghost
Copy link

ghost commented Apr 27, 2017

View the complete job log.

Lint

Passed

@ghost
Copy link

ghost commented Apr 27, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 3bd2134
Using browser at version BuildID 20170427100655; SourceStamp 0b77ed3f26c5335503bc16e85b8c067382e7bb1e
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html
Subtest Results Messages
OK
tokenization should skip window features separators before name FAIL assert_equals: "=noopener" should activate feature "noopener" expected null but got object "[object Window]"
feature name should be converted to ASCII lowercase FAIL assert_equals: "NOOPENER" should activate feature "noopener" expected null but got object "[object Window]"
after name, tokenization should skip window features separators that are not "=" or "," FAIL assert_equals: "noopener\n =" should activate feature "noopener" expected null but got object "[object Window]"
Tokenizing should ignore window feature separators except "," after initial "=" and before value FAIL assert_equals: "noopener= yes" should activate feature "noopener" expected null but got object "[object Window]"
Tokenizing should read characters until first window feature separator as value FAIL assert_equals: "noopener=noopener" should set "noopener" expected null but got object "[object Window]"
"noopener" should be based on name (key), not value FAIL assert_equals: "noopener=false" should activate feature "noopener" expected null but got object "[object Window]"
invalid feature names should not tokenize as "noopener" PASS

@ghost
Copy link

ghost commented Apr 27, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 3bd2134
Using browser at version 59.0.3071.25 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html
Subtest Results Messages
OK
tokenization should skip window features separators before name FAIL `assert_equals: "
feature name should be converted to ASCII lowercase PASS
after name, tokenization should skip window features separators that are not "=" or "," FAIL assert_equals: "foo noopener=1" should activate feature "noopener" expected null but got object "[object Window]"
Tokenizing should ignore window feature separators except "," after initial "=" and before value PASS
Tokenizing should read characters until first window feature separator as value PASS
"noopener" should be based on name (key), not value PASS
invalid feature names should not tokenize as "noopener" FAIL assert_not_equals: "noopener" should NOT activate feature "noopener" got disallowed value null

@lyzadanger
Copy link
Contributor

This definitely seems like a change I can get behind :D. 👍

@annevk annevk merged commit 3725474 into web-platform-tests:master Apr 27, 2017
@annevk
Copy link
Member

annevk commented Apr 27, 2017

Sorry for not spotting that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants