From b99e156600e9730152eebbf4b765b0eb96373205 Mon Sep 17 00:00:00 2001 From: nivida Date: Wed, 9 Oct 2019 08:05:23 +0900 Subject: [PATCH 1/3] supportsSubscriptions method added to providers --- packages/web3-providers-http/src/index.js | 3 +++ packages/web3-providers-ipc/src/index.js | 7 +++++++ packages/web3-providers-ws/src/index.js | 7 +++++++ 3 files changed, 17 insertions(+) diff --git a/packages/web3-providers-http/src/index.js b/packages/web3-providers-http/src/index.js index 299cc2a2bfc..3a30675a71a 100644 --- a/packages/web3-providers-http/src/index.js +++ b/packages/web3-providers-http/src/index.js @@ -120,5 +120,8 @@ HttpProvider.prototype.disconnect = function () { //NO OP }; +HttpProvider.prototype.supportsSubscriptions = function () { + return false; +}; module.exports = HttpProvider; diff --git a/packages/web3-providers-ipc/src/index.js b/packages/web3-providers-ipc/src/index.js index 8e8002bbfad..7447d2a4fff 100644 --- a/packages/web3-providers-ipc/src/index.js +++ b/packages/web3-providers-ipc/src/index.js @@ -311,5 +311,12 @@ IpcProvider.prototype.reset = function () { this.addDefaultEvents(); }; +/** + * @returns {boolean} + */ +IpcProvider.prototype.supportsSubscriptions = function () { + return true; +}; + module.exports = IpcProvider; diff --git a/packages/web3-providers-ws/src/index.js b/packages/web3-providers-ws/src/index.js index 3142fc19bcb..650cc7207ba 100644 --- a/packages/web3-providers-ws/src/index.js +++ b/packages/web3-providers-ws/src/index.js @@ -404,4 +404,11 @@ WebsocketProvider.prototype.disconnect = function () { } }; +/** + * @returns {boolean} + */ +WebsocketProvider.prototype.supportsSubscriptions = function () { + return true; +}; + module.exports = WebsocketProvider; From a5fa01fb302bc1dbbec2b66f098b62b63e2ad821 Mon Sep 17 00:00:00 2001 From: nivida Date: Wed, 9 Oct 2019 08:07:40 +0900 Subject: [PATCH 2/3] CHANGELOG.md updated --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30f11a60cd2..3aa8016aac0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -54,6 +54,7 @@ Released with 1.0.0-beta.37 code base. - localStorage support detection added (#3031) - getNetworkType method extended with Görli testnet (#3095) +- supportsSubscriptions method added to providers (#3116) ### Fixed From 56f78b501ef64b88a0c80a42bc59e71284460343 Mon Sep 17 00:00:00 2001 From: nivida Date: Wed, 9 Oct 2019 08:27:18 +0900 Subject: [PATCH 3/3] funcDocs updated for providers --- packages/web3-providers-http/src/index.js | 6 ++++++ packages/web3-providers-ipc/src/index.js | 3 +++ packages/web3-providers-ws/src/index.js | 3 +++ 3 files changed, 12 insertions(+) diff --git a/packages/web3-providers-http/src/index.js b/packages/web3-providers-http/src/index.js index 3a30675a71a..1aa75032607 100644 --- a/packages/web3-providers-http/src/index.js +++ b/packages/web3-providers-http/src/index.js @@ -120,6 +120,12 @@ HttpProvider.prototype.disconnect = function () { //NO OP }; +/** + * Returns the desired boolean. + * + * @method supportsSubscriptions + * @returns {boolean} + */ HttpProvider.prototype.supportsSubscriptions = function () { return false; }; diff --git a/packages/web3-providers-ipc/src/index.js b/packages/web3-providers-ipc/src/index.js index 7447d2a4fff..e0fcdeefb70 100644 --- a/packages/web3-providers-ipc/src/index.js +++ b/packages/web3-providers-ipc/src/index.js @@ -312,6 +312,9 @@ IpcProvider.prototype.reset = function () { }; /** + * Returns the desired boolean. + * + * @method supportsSubscriptions * @returns {boolean} */ IpcProvider.prototype.supportsSubscriptions = function () { diff --git a/packages/web3-providers-ws/src/index.js b/packages/web3-providers-ws/src/index.js index 650cc7207ba..b9a271f5cd6 100644 --- a/packages/web3-providers-ws/src/index.js +++ b/packages/web3-providers-ws/src/index.js @@ -405,6 +405,9 @@ WebsocketProvider.prototype.disconnect = function () { }; /** + * Returns the desired boolean. + * + * @method supportsSubscriptions * @returns {boolean} */ WebsocketProvider.prototype.supportsSubscriptions = function () {