Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Use the ethereum-blackhole (the 0x address) for the from address for tests on mainnet and testnet #6689

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Use the ethereum-blackhole (the 0x address) for the from address for tests on mainnet and testnet #6689

merged 7 commits into from
Jan 8, 2024

Conversation

@Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Jan 4, 2024 •
edited
Loading

Description

Fixes #6640

The tests can now be run with no issues. Tested here: https://github.com/web3/web3.js/actions/runs/7419127171/job/20188191757?pr=6689

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba linked an issue Jan 4, 2024 that may be closed by this pull request
mainnet release tests - estimategas error #6640
Closed
@github-actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 618 KB 618 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 601 KB 601 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@github-actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Benchmark

Benchmark suite Current: c6672af Previous: 6c075db Ratio
processingTx 9498 ops/sec (±3.88%) 9301 ops/sec (±4.81%) 0.98
processingContractDeploy 40389 ops/sec (±7.61%) 39129 ops/sec (±7.62%) 0.97
processingContractMethodSend 20324 ops/sec (±4.92%) 19443 ops/sec (±5.19%) 0.96
processingContractMethodCall 40389 ops/sec (±5.40%) 38971 ops/sec (±6.34%) 0.96
abiEncode 47495 ops/sec (±6.58%) 44252 ops/sec (±6.92%) 0.93
abiDecode 31486 ops/sec (±7.41%) 30419 ops/sec (±8.89%) 0.97
sign 1641 ops/sec (±1.09%) 1656 ops/sec (±4.08%) 1.01
verify 375 ops/sec (±0.71%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6672af
Status: ✅  Deploy successful!
Preview URL: https://13f1e543.web3-js-docs.pages.dev
Branch Preview URL: https://6640-mainnet-release-tests-e.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

Merging #6689 (c6672af) into 4.x (b188714) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##              4.x    #6689   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files         214      214           
  Lines        8171     8171           
  Branches     2200     2200           
=======================================
  Hits         7472     7472           
  Misses        699      699
Flag Coverage Δ
UnitTests 91.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review January 5, 2024 07:37
jdevcs
jdevcs reviewed Jan 5, 2024
View reviewed changes
.github/workflows/e2e_network_tests.yml
INFURA_MAINNET_HTTP: ${{ secrets.INFURA_MAINNET_HTTP }}
MODE: ${{ matrix.mode }}
TEST_ACCOUNT_ADDRESS: ${{ fromJSON('{"sepolia":"0xa127C5E6a7E3600Ac34A9a9928E52521677e7211","mainnet":"0x98AF911164f9d4E0f5983ed114949c3Bfe3ADc9d"}')[matrix.network] }}
TEST_ACCOUNT_ADDRESS: ${{ fromJSON('{"sepolia":"0x0000000000000000000000000000000000000000","mainnet":"0x0000000000000000000000000000000000000000"}')[matrix.network] }}
Copy link
Contributor

@jdevcs jdevcs Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blackbox Tests were not failing on sepolia, could you double check old logs for it. and run tests with above change. thanks

Copy link
Contributor Author

@Muhammad-Altabba Muhammad-Altabba Jan 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdevcs , yes tests where not failing for sepolia. But I thought to use an address that would never cause the tests to fail in the future as a precaution. Or what do you think?
And yes, I run the tests and they all run with success here: https://github.com/web3/web3.js/actions/runs/7419127171/job/20188191757?pr=6689
Thanks,

@Muhammad-Altabba Muhammad-Altabba merged commit cc7ff1f into 4.x Jan 8, 2024
@Muhammad-Altabba Muhammad-Altabba deleted the 6640-mainnet-release-tests-estimategas-error branch January 8, 2024 19:47
@luu-alex luu-alex mentioned this pull request Jan 15, 2024
Closed
@luu-alex luu-alex mentioned this pull request Jan 16, 2024
Merged
17 tasks
@affiliatedkat affiliatedkat mentioned this pull request May 7, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@luu-alex luu-alex Awaiting requested review from luu-alex

2 more reviewers

@avkos avkos avkos approved these changes

@jdevcs jdevcs jdevcs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mainnet release tests - estimategas error

4 participants

@Muhammad-Altabba @avkos @jdevcs