Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate dApp Guide #7334

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Intermediate dApp Guide #7334

merged 4 commits into from
Oct 21, 2024

Conversation

danforbes
Copy link
Contributor

Closes #7038

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 641.05 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 621.56 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 148 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 5493b5a Previous: 822f8c1 Ratio
processingTx 23161 ops/sec (±7.90%) 22958 ops/sec (±7.21%) 0.99
processingContractDeploy 40277 ops/sec (±7.36%) 40077 ops/sec (±7.24%) 1.00
processingContractMethodSend 17113 ops/sec (±6.62%) 15807 ops/sec (±8.02%) 0.92
processingContractMethodCall 27955 ops/sec (±7.58%) 27362 ops/sec (±8.03%) 0.98
abiEncode 46072 ops/sec (±6.40%) 44555 ops/sec (±6.70%) 0.97
abiDecode 31638 ops/sec (±7.09%) 30694 ops/sec (±6.83%) 0.97
sign 1588 ops/sec (±0.86%) 1590 ops/sec (±1.37%) 1.00
verify 364 ops/sec (±2.33%) 365 ops/sec (±0.53%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (822f8c1) to head (5493b5a).
Report is 2 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7334   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         216      216           
  Lines        8469     8469           
  Branches     2341     2341           
=======================================
  Hits         7999     7999           
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@krzysu krzysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great guide! It would be helpful to know how many people are actually reading our guides, though.

Closes #7324
Replaces #7325
Co-authored-by: Kris <605420+krzysu@users.noreply.github.com>
@danforbes danforbes merged commit fab66e9 into 4.x Oct 21, 2024
54 checks passed
@danforbes danforbes deleted the feat/docs/intermediate-dapp branch October 21, 2024 15:00
@luu-alex luu-alex mentioned this pull request Nov 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in subscribe migration guide Add metamask signing and sending transaction examples to the docs
4 participants