Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove join_room from setup #6

Open
piranna opened this issue Aug 24, 2012 · 3 comments
Open

Remove join_room from setup #6

piranna opened this issue Aug 24, 2012 · 3 comments

Comments

@piranna
Copy link

piranna commented Aug 24, 2012

Join_room is a webrtc.io artifact that is not on the standard, and also it would not be useful if you don't need a open, unlimited room (for example one with a members limit) or with PeerConnection. I propose to remove it from the connect logic and put it on an independent function that can be called after that by the programmer.

@YurySolovyov
Copy link

agree, we ca track clients in a better way, and also, i think there is no need to connect everyone in a room with peerConnection, it has to be done explicitly in a code

@dennismartensson
Copy link
Member

I think this is valid point. How do ou propuse that we do this?

@YurySolovyov
Copy link

you can store sockets in an object using ids as keys.
for room functionality, there is several ways:

  • rooms field in a socket
  • rooms object that contains ids of sockets in a particular room
  • or even both

IMO peer connections should be established by demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants