Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct type on gecko driver params to be logNoTruncate instead of logNoTruncated #567

Conversation

AtofStryker
Copy link
Contributor

Fixes the logNoTruncated typing to be logNoTruncate. This can be seen when running geckodriver --help

Screenshot 2024-10-09 at 3 04 00 PM

Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@christian-bromann christian-bromann merged commit 138fde4 into webdriverio-community:main Oct 9, 2024
5 checks passed
@wdio-bot
Copy link
Contributor

wdio-bot commented Oct 9, 2024

Hey AtofStryker 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants