Introduce TypeReference
#1151
Closed
Introduce TypeReference
#1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do this in getType?
This can be used to construct a schema without having to link every types together via a central registry or by using callbacks. It makes the types more independent and only on runtime they will have to all resolve to the correct type.
spawnia
reviewed
May 24, 2022
|
|
||
| namespace GraphQL\Type\Definition; | ||
|
|
||
| class TypeReference extends Type implements NullableType, NamedType |
There was a problem hiding this comment.
I don't see why this has to extend Type, it can not be used as such.
|
Just merged #1104 which changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1149