test: hashes inside @font-face url
#678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
requested changes
Feb 15, 2018
test/urlTest.js
Outdated
| @@ -184,6 +184,12 @@ describe("url", function() { | |||
| test("font face with url", "@font-face { src: url(regular.woff) format('woff'), url(~truetype/regular.ttf) format('truetype') }", [ | |||
| [1, "@font-face { src: url(regular.woff) format('woff'), url(~truetype/regular.ttf) format('truetype') }", ""] | |||
| ], "?-url"); | |||
| test("font face with url", "@font-face { src: url(Mark Simonson - Proxima Nova Alt Regular-webfont.eot?#iefix) format('embedded-opentype'), url(~opentype/Mark Simonson - Proxima Nova Alt Regular-webfont.eot?#iefix) format('embedded-opentype') }", [ | |||
There was a problem hiding this comment.
indent seems to be off (?) :)
michael-ciniawsky
changed the title
font-face at rule@font-face url
alexander-akait
force-pushed
the
issue-668
branch
from
2264cbd to
cf4e32f
Compare
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 11 11
Lines 380 380
Branches 89 89
=======================================
Hits 376 376
Misses 4 4Continue to review full report at Codecov.
|
|
@michael-ciniawsky fixed |
michael-ciniawsky
approved these changes
Feb 15, 2018
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 5 (nice to have)
labels
This was referenced Mar 16, 2018
This was referenced Mar 19, 2018
Bump css-loader from 0.28.8 to 0.28.11
Armour/express-webpack-react-redux-typescript-boilerplate#226
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
yes
If relevant, did you update the README?
not matter
Summary
Ref: #668
Other information