-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: source map sources
and file
paths
#753
Changes from 1 commit
e4497c6
7f4f7a8
8cf05a9
027c8ca
32e7f46
c0669ab
ffdd935
16c317a
68bd963
26680b0
c2e272f
625ffb1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -179,16 +179,8 @@ module.exports = function processCss(inputSource, inputMap, options, callback) { | |
parserPlugin(parserOptions) | ||
]); | ||
|
||
var postCssFrom; | ||
if (options.query.legacySourceMaps !== false) { | ||
// we need a prefix to avoid path rewriting of PostCSS | ||
postCssFrom = "/css-loader!" + options.from; | ||
} else { | ||
postCssFrom = options.from; | ||
} | ||
|
||
pipeline.process(inputSource, { | ||
from: postCssFrom, | ||
from: options.from, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Break maps in many cases There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you referring to the existing test suite? It is expected that it broke. I held off on updating the test suite as the comments in this review would determine how it would need to be updated. The existing test suite is still using assumptions about source maps prior to the fix in this PR. I currently have the feedback I need and I intend to update the test suite prior to setting up the test repo. If it isn't the test suite, is there a specific scenario you can describe that I can look into? |
||
to: options.to, | ||
map: options.sourceMap ? { | ||
prev: inputMap, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.