You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 29, 2019. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the ignoreOrder checks added by #166 in the master branch. I realize the optimum solution for this issue is to migrate to Webpack 2 but since I'd consider this issue fairly debilitating, I think a fix should be present for those who need something in their production environments right away and can't go through the steps to migrate.
@keepitreal Support legacy code (options, functions, checks, and etc) is a bad practice (we use semver to avoid accumulation this legacy stuff). I would advise you to find the time and go to webpack v2 or do fork and use this fork for own packages, where your use webpack v1. Not here. Thanks!
@bebraw @d3viant0ne We can still cut a release for v1.x? The question is if we want to take the eventual risk that this might break something in general, if not then better close the PR :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ignoreOrder checks added by #166 in the master branch. I realize the optimum solution for this issue is to migrate to Webpack 2 but since I'd consider this issue fairly debilitating, I think a fix should be present for those who need something in their production environments right away and can't go through the steps to migrate.