-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(index): don't set to
value (options
)
#339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing `to` it truncates the output source map file path to just the path base name. By removing this value the paths are now correct. The implementation of this logic is found [here](https://github.com/postcss/postcss/blob/master/lib/map-generator.es6#L179-L195)
camshaft
requested review from
alexander-akait and
michael-ciniawsky
as code owners
February 25, 2018 20:12
michael-ciniawsky
changed the title
Remove
fix(index): don't set Feb 25, 2018
to
options valueto
value for source maps
michael-ciniawsky
changed the title
fix(index): don't set
fix(index): don't set Feb 25, 2018
to
value for source mapsto
value (options
)
michael-ciniawsky
approved these changes
Feb 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camshaft Thx, Could you show a screenshot of the devTool
panel for reference, if this definitely fixes the issue ?
Released in |
This was referenced Feb 26, 2018
This was referenced Mar 19, 2018
This was referenced Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing
to
it truncates the output source map file path to just the path base name. By removing this value the paths are now correct.The implementation of this logic is found here
Type
SemVer
Issues
Checklist