Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

fix(index): escape invalid characters #43

Merged
merged 4 commits into from
Nov 17, 2017
Merged

fix(index): escape invalid characters #43

merged 4 commits into from
Nov 17, 2017

Commits on Nov 14, 2017

  1. Handle special whitespace characters. 

    If your raw text has a string with Line separator or Paragraph separator,
they need to be handled outside of JSON.stringify:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#Issue_with_plain_JSON.stringify_for_use_as_JavaScript

The fix here is to replace those characters as directed in the MDN article above.

I also changed the formatting from tabs to 2 spaces :-p
    @joeheyming
    joeheyming committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    78cb753 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2017

  1. Address code review.

    @joeheyming
    joeheyming committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    c53a7de View commit details
    Browse the repository at this point in the history

  2. Rename some variables.

    @joeheyming
    joeheyming committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    6f8b707 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2017

  1. Remove cacheable. 

    Turns out cacheable is only used in webpack 1.
So we are removing it.
    @joeheyming
    joeheyming committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    c047cea View commit details
    Browse the repository at this point in the history